-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove/reduce unused or private methods and add tests to SkiaGoldClient
#50844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, when I did the golden harvester I remember avoiding this code like it was radioactive since it was missing tests. This is much appreciated.
@Piinks I am still happy to receive after-the-fact feedback and will do a follow up PR as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to sound like a broken record, but I did not write the Gold implementation for flutter/engine. @mdebbar did and would probably be best to look this over.
I can take a look tomorrow, but will likely need to brush up on it in general first.
…143911) flutter/engine@bf5c003...7eeb697 2024-02-22 [email protected] Add view focus direction detection to flutter web. (flutter/engine#50843) 2024-02-22 [email protected] Add a similar `runIf` guard to `web_engine` as web framework. (flutter/engine#50846) 2024-02-22 [email protected] Add scheduleWarmUpFrame (flutter/engine#50570) 2024-02-22 [email protected] Remove/reduce unused or private methods and add tests to `SkiaGoldClient` (flutter/engine#50844) 2024-02-22 [email protected] Clean up contributing formatting, add a Skia gold callout (flutter/engine#50828) 2024-02-21 [email protected] Make Android Studio be able to run android embedding unit tests out of the box (flutter/engine#50840) 2024-02-21 [email protected] Shift some deps to //flutter/third_party (flutter/engine#50830) 2024-02-21 [email protected] Make the view focus binding report focus transitions across elements. (flutter/engine#50610) 2024-02-21 [email protected] [macOS] Wrap FlutterEngineTest in autoreleasepool (flutter/engine#50832) 2024-02-21 [email protected] Update the vulkan_glfw sample for the latest roll of vulkan-deps (flutter/engine#50839) 2024-02-21 [email protected] Roll Skia from 8fa858855820 to 57490c8d257e (6 revisions) (flutter/engine#50833) 2024-02-21 [email protected] Starts a .ci.yaml parser (flutter/engine#50783) 2024-02-21 [email protected] Roll Dart SDK from f344e2266468 to 0f0f7400c38a (6 revisions) (flutter/engine#50837) 2024-02-21 [email protected] [Windows] Fix top-level message procedure order (flutter/engine#50797) 2024-02-21 [email protected] Tweak verbose log messages in ImageReaderSurfaceProducer (flutter/engine#50831) 2024-02-21 [email protected] Add a throw statement for imgtestAdd non 0 exit codes. (flutter/engine#50829) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…ests`. (#51325) I think this restores the behavior prior to #50844 without making the client code faulty. I'll file a follow-up issue, I don't think `golden_tests_harvester` should accept running if `GOLDCTL` isn't set: flutter/flutter#144948. /cc @godofredoc
…ests`. (flutter#51325) I think this restores the behavior prior to flutter#50844 without making the client code faulty. I'll file a follow-up issue, I don't think `golden_tests_harvester` should accept running if `GOLDCTL` isn't set: flutter/flutter#144948. /cc @godofredoc
@Piinks correctly pointed out we had to make a number of changes to the engine's
SkiaGoldClient
and we had no test coverage (#50829, #50826).This corrects the problem.
I am not in love with these tests (they could be less snapshot-y), but the mechanisms I need to write better tests is beyond what I can spend ~1-2 hours on (flutter/flutter#133569).
/cc @dnfield @mdebbar